Conversation
| SV_PLUGINS = [ | ||
| "CADD" | ||
| ] |
There was a problem hiding this comment.
Is CADD really the only plugin we want to run for Structural variants? Should all others be disabled (as this code does)?
There was a problem hiding this comment.
the only other candidate is Phenotype, but we will have separate data store for it soon.
There was a problem hiding this comment.
@nakib103 As the phenotype store is still in design, I'd say we should keep the current phenotype plugin enabled until we have access to the new data.
There was a problem hiding this comment.
Phenotype plugin data (the GFF3s) has the phenotype for structural variants. But I don't think anyone ever tested/worked on the plugin to see if it works with that data (you might get lots of Pheno against short variants getting attached to the SVs).
But if you already have tested and have good hunch about it I can add the plugin.
There was a problem hiding this comment.
| plugin_files = [] | |
| if structural_variant: | |
| sv = os.path.join(plugin_data_dir, "CADD_prescored_variants.tsv.gz") | |
| plugin_files = [sv] | |
| else: | |
| if species == "sus_scrofa": | |
| snv = os.path.join(plugin_data_dir, "ALL_pCADD-PHRED-scores.tsv.gz") | |
| plugin_files = [snv] | |
| else: | |
| snv = os.path.join( | |
| plugin_data_dir, f"CADD_{assembly}_1.7_whole_genome_SNVs.tsv.gz" | |
| ) | |
| indels = os.path.join(plugin_data_dir, f"CADD_{assembly}_1.7_InDels.tsv.gz") | |
| plugin_files = [snv, indels] | |
| if len(plugin_files) > 0: | |
| check_plugin_files(plugin, plugin_files) | |
| return f"CADD,{','.join(plugin_files)}" | |
| else: | |
| return '' |
There was a problem hiding this comment.
The suggested change here should span lines 325 - 344, for some reason it doesn't seem to get the formatting right (It's not just adding 21 lines but rather replacing the 19 existing ones with the 21 above)
There was a problem hiding this comment.
I have added the suggestion with slight modification.
There was a problem hiding this comment.
Why still repeating the check_plugin_files function-calling and the return value formatting logic? My suggestion was mostly about not repeating that logic (it only calls check_plugin_files and formats and returns the CLI arg on one line by making use of the plugin_files array).
There was a problem hiding this comment.
ah that might be right, it was hard reading with wrapped lines. I kept it this way for better readability.
2 participants
No description provided.